Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style enforcing #69

Merged
merged 168 commits into from
Dec 5, 2024
Merged

Code style enforcing #69

merged 168 commits into from
Dec 5, 2024

Conversation

marenz2569
Copy link
Member

@marenz2569 marenz2569 commented Sep 24, 2024

This PR creates clang-tidy rules, a CI action to enforce them, adds doc-strings and refactors FIRESTARTER to aid the clang-tidy rules. All changes should be non functional.
Follow up tickets were created: #71, #72, #73, #74, #75, #76, #77, #78, #81, #82, #83, #84, #85, #86, #87 and #90.

… lots of reinterpret_cast and pointer magic. refactor dump register code.
…an up memory management for the high-load routine.
@marenz2569 marenz2569 requested a review from rschoene November 8, 2024 16:37
@marenz2569 marenz2569 marked this pull request as ready for review November 8, 2024 16:37
@marenz2569
Copy link
Member Author

marenz2569 commented Nov 8, 2024

Open Points:

  • Test functionality of FIRESTARTER:
    • Measurement
    • Optimization
    • Watchdog
    • CUDA
    • HIP
    • OneAPI
    • Error detection
    • Dump registers
  • make sure the include style is consistent

@rschoene rschoene merged commit fcbda57 into master Dec 5, 2024
202 checks passed
@rschoene rschoene deleted the code-style-enforcing branch December 5, 2024 12:47
marenz2569 added a commit that referenced this pull request Dec 5, 2024
@marenz2569 marenz2569 restored the code-style-enforcing branch December 5, 2024 13:33
@marenz2569 marenz2569 deleted the code-style-enforcing branch December 5, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants