Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor thread affinity #96

Merged
merged 30 commits into from
Dec 19, 2024
Merged

Refactor thread affinity #96

merged 30 commits into from
Dec 19, 2024

Conversation

marenz2569
Copy link
Member

@marenz2569 marenz2569 commented Dec 9, 2024

This PR is part of the preparation for ARM support (#79). It closes #74.

This PR splits code of the fat Environment class. Makes use of hwloc for cpubinding. Splits of command line parsing for cpu binding. Creates tests for the hwloc wrapper and the cpu bind command line parsing.

@marenz2569
Copy link
Member Author

marenz2569 commented Dec 9, 2024

  • macos cpu binding not possible with hwloc
  • test cpubind cmd line parsing
  • test hwloc topology parsing
  • remove thread affinity toggle

@marenz2569 marenz2569 changed the base branch from marenz.test-payload-generation to master December 9, 2024 17:06
@marenz2569 marenz2569 mentioned this pull request Dec 11, 2024
8 tasks
@marenz2569 marenz2569 requested a review from rschoene December 11, 2024 15:45
@marenz2569 marenz2569 marked this pull request as ready for review December 11, 2024 15:45
Copy link
Member

@rschoene rschoene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two comments

src/firestarter/LoadWorker.cpp Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@marenz2569 marenz2569 merged commit 96ca3f7 into master Dec 19, 2024
42 checks passed
@marenz2569 marenz2569 deleted the marenz.hwloc-thread-affinity branch December 19, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace CPU_SET calls with thread affinity from hwloc
2 participants