-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table gcp_redis_instance
. Closes #478
#482
Conversation
@madhushreeray30 while updating the go SDK version for GCP did you check for breaking changes? Does this affect other tables? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madhushreeray30 , I left a few review comments could you please take a look? Thanks!
Once changes have been made please make sure the pagination and the Get Config is working as expected.
} | ||
|
||
var location string | ||
matrixLocation := d.EqualsQualString(matrixKeyRedisLocation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the above code I believe we have to specify the location_id
in where clause. Do we need this block of code to get the location value from the matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the above code I believe we have to specify the
location_id
in where clause. Do we need this block of code to get the location value from the matrix?
@ParthaI we require this because the response of the list call returns in the form us-central1-b
where as the getMatrix give as us-central1
so we need to remove the AZ that's why we need this.
Integration test logs
Logs
Example query results
Results