Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the cache key issue in SecretManager service client creation #624

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Jul 30, 2024

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
> select * from gcp_redis_instance
+---------+--------------+--------+---------------+-------------------------+---------------+-------------------+--------------------+------------+------+---------------------+---------------------------+-------+----------------+------>
| name    | display_name | labels | location_id   | alternative_location_id | redis_version | reserved_ip_range | secondary_ip_range | host       | port | current_location_id | create_time               | state | status_message | redis>
+---------+--------------+--------+---------------+-------------------------+---------------+-------------------+--------------------+------------+------+---------------------+---------------------------+-------+----------------+------>
| test-pc |              | <null> | us-central1-b |                         | REDIS_7_0     | 10.16.65.0/29     |                    | 10.16.65.3 | 6379 | us-central1-b       | 2024-07-30T17:12:21+05:30 | 2     |                | <null>
+---------+--------------+--------+---------------+-------------------------+---------------+-------------------+--------------------+------------+------+---------------------+---------------------------+-------+----------------+------

@ParthaI ParthaI requested a review from misraved July 30, 2024 12:02
@ParthaI ParthaI self-assigned this Jul 30, 2024
@misraved misraved merged commit e872cd7 into main Jul 30, 2024
1 check passed
@misraved misraved deleted the fix-cachekey-issue-table branch July 30, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants