Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gcp_compute_instance_group_manager table #669

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Oct 19, 2024

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
> select
  m.name as manager_name, m.target_size, m.status -> 'isStable' as is_stable,
  g.name as group_name,
  g.size as group_size
from
  gcp_compute_instance_group_manager as m,
  gcp_compute_instance_group as g
where
  m.instance_group ->> 'name' = g.name;
+----------------------------------------------------+-------------+-----------+----------------------------------------------------+------------+
| manager_name                                       | target_size | is_stable | group_name                                         | group_size |
+----------------------------------------------------+-------------+-----------+----------------------------------------------------+------------+
| gke-project1234567-pool-docker-build--01234567-grp | 0           | true      | gke-project1234567-pool-docker-build--01234567-grp | 0          |
| gke-project12345-with-local-ssd-01234-12345678-grp | 0           | true      | gke-project12345-with-local-ssd-01234-12345678-grp | 0          |
| gke-project1234567-pool-with-local-ss-23456789-grp | 0           | true      | gke-project1234567-pool-with-local-ss-23456789-grp | 0          |
| gke-project12345-docker-build-0123456-34567890-grp | 0           | true      | gke-project12345-docker-build-0123456-34567890-grp | 0          |
| gke-tooling-service-pool-012345678910-45678901-grp | 2           | true      | gke-tooling-service-pool-012345678910-45678901-grp | 2          |
| gke-project1234567-onegit-service-poo-56789012-grp | 2           | true      | gke-project1234567-onegit-service-poo-56789012-grp | 2          |
| gke-project1234567-pool-spot-ssd-2345-67890123-grp | 4           | true      | gke-project1234567-pool-spot-ssd-2345-67890123-grp | 4          |
| gke-project12345-spot-ssd-01234567514-78901234-grp | 1           | <null>    | gke-project12345-spot-ssd-01234567514-78901234-grp | 1          |
+----------------------------------------------------+-------------+-----------+----------------------------------------------------+------------+

@pdecat pdecat changed the title feat/gcp compute instance group manager feat: add gcp_compute_instance_group_manager table Oct 19, 2024
@pdecat pdecat force-pushed the feat/gcp_compute_instance_group_manager branch from b1fbf96 to d2851b6 Compare October 19, 2024 14:06
@pdecat pdecat changed the title feat: add gcp_compute_instance_group_manager table feat: add gcp_compute_instance_group_manager table Oct 19, 2024
@pdecat pdecat force-pushed the feat/gcp_compute_instance_group_manager branch from d2851b6 to 540e565 Compare October 19, 2024 14:58
@pdecat pdecat force-pushed the feat/gcp_compute_instance_group_manager branch from 540e565 to 6541e39 Compare October 19, 2024 14:59
@misraved misraved added the hacktoberfest-accepted This pull request has been accepted for Hacktoberfest label Oct 22, 2024
@misraved misraved self-requested a review October 28, 2024 14:01
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdecat could you please take a look at the minor review comments 👍!!

Thanks once again for the new table 😄, great work!!

docs/tables/gcp_compute_instance_group_manager.md Outdated Show resolved Hide resolved
pdecat and others added 2 commits October 28, 2024 15:53
Co-authored-by: Ved misra <47312748+misraved@users.noreply.github.com>
Co-authored-by: Ved misra <47312748+misraved@users.noreply.github.com>
@pdecat
Copy link
Contributor Author

pdecat commented Oct 28, 2024

Hi @misraved, thanks, I've applied your proposed changes!

@misraved misraved merged commit 50d4c0a into turbot:main Oct 28, 2024
1 check passed
@pdecat pdecat deleted the feat/gcp_compute_instance_group_manager branch October 28, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted This pull request has been accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants