Accepting CSV's fmtparams on import_from_csv
#209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@berinhard thanks for the PR and sorry for so long! |
turicas
force-pushed
the
develop
branch
2 times, most recently
from
fa144f0 to
bbb2c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@turicas I didn't add tests yet and I'm opening this PR just to make sure if you're ok with this small change on the API would fix #208. Reference on python doc for CSV reader params.
The usage would be:
What do you think? If you're ok, I can add tests to this.
PS.: with this change, the old tests keep passing =)