Better mailto handling on Android #5519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When using the Android Developers' recommendations for sending email intents with the
mailtoscheme, Tutanota will use it (even though empty) to create the mail editor, ignoring the other fields like addresses and subject (cf. WebCommonNativeFacade.ts#L35-L61).This PR aims at improving the way the app handles an email intent by checking that the scheme is not empty (i.e. that it contains at least one valid field).
If the scheme does not hold any meaningful data, then
mailToUrlStringwill be empty, and the mail editor will be created using the fields from the intent's extras.Thanks.