Initialize MailModel.folders as empty Map #7967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close: #7820 Co-authored-by: ivk <ivk@tutao.de>
Issue caused by inline images not being replaced after a loadAll call (without notify) which sanitizes mail body. This is due to the replaceInlineImages call being inside a loadCompleteNotification listener. Fixed by calling loadAll *with* notify in reply. loadAll is also now only called when necessary. Close #6523 Co-authored-by: ivk <ivk@tutao.de>
Crash caused by an uncaught exception due to popover requiring position information on iPad only but not on iPhone. Close #7914 Co-authored-by: paw-hub <104824185+paw-hub@users.noreply.github.com>
Close #7125 Co-authored-by: bir <bir@tutao.de>
On some systems, a backend may not be detected correctly. In a lot of cases, this can occur if the user is not using one of a hardcoded list of desktop environments (you can see this list in xdg_util.cc as well as key_storage_util_linux.cc in GetDesktopEnvironment and SelectBackend respectively in Chromium's source code), and it determines this using environment variables. Basically, if Chromium is unable to detect your desktop environment this way, safeStorage will not be available in any way except basic_text. We don't really have any control over this outside of the preselectGnomeLibsecret() method which may or may not work, but users can override it with CLI args or just set an app password. As such, this commit allows basic_text to be used as a backend. Closes #7257
Issue caused by caching the initially selected language and not changing current language while switching language. Resolved by resetting lazyloaded when switching the system language. close: 7335
Made congratulation.svg same size as other svg files in welcome page to avoid different image sizes close: #6853 Co-authored-by: ivk <ivk@tutao.de>
5 tasks
This potentially solves a reported issue that we don't quite know how to reproduce. MailModel.folders.size is being read before MailModel.folders is set to a Map. Close #7966 Co-authored-by: paw <paw-hub@users.noreply.github.com>
hrb-hub
force-pushed
the
7966-init-mailmodel-folders
branch
from
e8b5b46
to
0868bac
Compare
|
I would hold this off until we get labels in, we did some refactoring there already |
charlag
force-pushed
the
dev-mail
branch
2 times, most recently
from
38600c8
to
a4f8354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This potentially solves a reported issue that we don't quite know how to reproduce. MailModel.folders.size is being read before MailModel.folders is set to a Map.
Close #7966