Clean up local admin handling code #8134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a new admin and an admin key rotation is pending we inform the admin that he must wait the rotation to finish first. tutadb#1905 Co-authored-by: vis <vis@tutao.de>
vitoreiji
force-pushed
the
crypto/1919
branch
from
32f9900 to
e673327
Compare
vitoreiji
force-pushed
the
crypto/1919
branch
2 times, most recently
from
272b702 to
9d23e32
Compare
tutadb#1906 Co-authored-by: vis <vis@tutao.de>
This key serves to authenticate the new admin group key to other admins, and should therefore be accessible by each admin. We have two options for this: the old admin group key, or each admin's existing user group key. The previous implementation derived the authentication key from the admin group key, which is not what was defined in the design of this key rotation process. tutadb#1906
When performing a user group key rotation after another admin already performed the admin group key rotation, each admin must validate the authenticity of the newly received admin group key and then encrypt it with their new user group key. tutadb#1909
vitoreiji
force-pushed
the
crypto/dev
branch
from
c6e8e0b to
6725f5d
Compare
These groups have been deleted and are no longer supported. It doesn't make sense talking about "global admins" anymore, so we just refer to them as "admins". tutadb#1919 Co-authored-by: Vitor Sakaguti <vis@tutao.de>
vitoreiji
force-pushed
the
crypto/1919
branch
from
9d23e32 to
05f8e1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tutadb#1919