Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logic to has signed up and has booked call #246

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

PrenSJ2
Copy link
Member

@PrenSJ2 PrenSJ2 commented Jul 1, 2024

Close #130

Now when you signup / book a call the values

has_signed_up

and

has_booked_call

are set

Testing

  • Setup
  • sign up from tc
  • see has signed up is true
  • book a call
  • see has booked call is true

@PrenSJ2 PrenSJ2 self-assigned this Jul 1, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.93%. Comparing base (acce74b) to head (c640c49).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   93.92%   93.93%   +0.01%     
==========================================
  Files          29       29              
  Lines        1712     1716       +4     
  Branches      228      228              
==========================================
+ Hits         1608     1612       +4     
  Misses         66       66              
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PrenSJ2 PrenSJ2 assigned DanJezeph15 and unassigned PrenSJ2 Jul 1, 2024
@DanJezeph15
Copy link
Contributor

DanJezeph15 commented Jul 2, 2024

  • I used postman to post to the http://localhost:8000/callbooker/sales/book/ endpoint with this info:
{
  "country": "GB",
  "phone": "+44 7852802656",
  "company_name": "Dan Sales Call Test",
  "estimated_income": "£10,000 - £20,000",
  "currency": "GBP",
  "price_plan": "startup",
  "website": "www.dantest.com",
  "bdr_person_id": "71",
  "utm_campaign": "",
  "utm_source": "direct",
  "admin_id": 2,
  "name": "violin s1skjms9sa4sd l2as44yridnth ",
  "email": "danielj+15041999@tutorcruncher.com",
  "meeting_dt": "2024-07-26T14:30:00.000Z",
  "call_type": "sales"
}

Which correctly created this in Hermes:
image
image

However I then went to signup on TC2, and it created a new organisation after I signed up:
image
image

It looks as tho _create_or_update_company only uses the tc2_agency_id currently which doesn't exist at the time of booking the call.

I see you have a TODO there now so maybe it's a different PR, if so then ignore this and LGTM!

Seb: have created a new issue #248

@DanJezeph15 DanJezeph15 assigned PrenSJ2 and unassigned DanJezeph15 Jul 2, 2024
@PrenSJ2 PrenSJ2 assigned HenryTraill and unassigned PrenSJ2 Jul 2, 2024
@HenryTraill HenryTraill merged commit 3e9188e into main Jul 3, 2024
2 checks passed
@HenryTraill HenryTraill deleted the fix-has-signed-up branch July 3, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Company has_signed_up and has_booked_call have no logic, dont work
4 participants