Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing originator to our SMS number #458

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

DanJezeph15
Copy link
Contributor

@DanJezeph15 DanJezeph15 commented Aug 22, 2023

Changes the from_name from the companies sms name to our TutorCruncher number. This is then used in self.messagebird.post where we set the originator to from_name

@DanJezeph15 DanJezeph15 self-assigned this Aug 22, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2706a28) 92.42% compared to head (19107ff) 92.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files          24       24           
  Lines        1293     1294    +1     
  Branches      146      146           
=======================================
+ Hits         1195     1196    +1     
  Misses         70       70           
  Partials       28       28           
Files Changed Coverage Δ
src/settings.py 100.00% <100.00%> (ø)
src/worker/sms.py 90.81% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomhamiltonstubber tomhamiltonstubber merged commit 234ccdc into master Aug 29, 2023
3 checks passed
@tomhamiltonstubber tomhamiltonstubber deleted the change-originator-to-our-number branch August 29, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants