SOF-1926 Update AdLibActions and -Pieces rank #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Segment ranks are being updated
KvelaGorrrrnio
approved these changes
Apr 26, 2024
| ) | ||
|
|
||
| for (const adLibAction of adLibActionsForSegment) { | ||
| const oldRankFraction: number = (adLibAction.display._rank ?? 1) % 1 |
There was a problem hiding this comment.
Any reason why ?? 1 instead of ?? 0? I assume that 0 is the intended default value.
There was a problem hiding this comment.
1 was intentional, but mostly to ensure that he rank did have a decimal value.
I don't think that's a strong argument so I have updated it to be 0.
| @@ -432,6 +437,36 @@ export async function handleUpdatedSegmentRanks( | |||
| ) | |||
| } | |||
|
|
|||
| function updateAdLibActionRanks(segmentExternalId: string, newRank: number, cache: CacheForIngest): void { | |||
There was a problem hiding this comment.
It would be nice for clarification that newRank is the newSegmentRank.
There was a problem hiding this comment.
I'm on the fence, but I have updated it.
RasmusAlbrektsen
approved these changes
Apr 26, 2024
LindvedKrvang
deleted the
SOF-1926/updateRanksOnAdLibActionsAndPiecesOnSegmentRankUpdated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ranks on AdLibActions and -Pieces are also updated when the Segment ranks are being updated