Minor/optional cleanup #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoking the 'pip' that is already installed in the virtualenv has the same effect.
Insert a paragraph break before "Simple usage:". Also, use "customized" instead of "extra" to describe the command line options being passed in the advanced example. (With "extra" it reads like the options are being appended to a list of existing - or default - command line options, but in fact there are _no_ command line options passed by default).
obscurerichard
approved these changes
May 23, 2024
There was a problem hiding this comment.
👍🏻 
This is more concise, I like it.
I'm probably going to be reworking this to eliminate the use of Docker to be more in line with what the isort and black plugins do, since FawltyDeps works best when run after you install the packages for the application under test, and in the same context. This is better than what was there though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three minor things I found while reviewing this. Feel free to take zero or more of these commits. :-)
Commits: