Preliminary bzlmod support #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann
force-pushed
the
bzlmod
branch
5 times, most recently
from
46c33d6
to
2eb02d8
Compare
This enables renaming the module to gazelle_cabal.
On for GHC version 9.4.5 and only for the example test for now. The alternative-deps tests and the root module are not yet ready to be tested with bzlmod enabled.
|
This will require an update of the required CI checks on GitHub. |
This was referenced Sep 26, 2023
avdv
reviewed
Sep 29, 2023
| use_repo(stack_snapshot, "stackage") | ||
| stack_snapshot.package(name = "directory") | ||
| stack_snapshot.package(name = "filepath") | ||
| stack_snapshot.package(name = "json") |
|
@Mergifyio rebase |
🛑 Unable to rebase the branch because the pull request is queuedIt's not possible to rebase this pull request because it is queued for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configures the
gazelle_cabalworkspace to be compatible with bzlmod as a dependency module. Meaning another module can depend on it via bzlmod, howevergazelle_cabalcannot itself be tested or built with bzlmod enabled, yet.This also configures the
exampleworkspace to be compatible with bzlmod as a root module. Meaning the example can be built and tested with bzlmod enabled.Enables bzlmod tests on CI, for now only for GHC version 9.4.5.
limitations / future work
testsare not built with bzlmod, yet.The
alternative-depstest requires renaming the stack snapshot workspace names tostackage-bandstackage-b-exe. This is currently not possible. One path would be anameattribute tostack_snapshot. However, this is not desirable as discussed in Allow using multiple stack snapshots in a MODULE.bazel rules_haskell#1962. Another approach is to use isolated extensions (requires Bazel 6.3) and remapping onuse_repo. But,use_repouses keyword argument syntax for the remapping target, andstackage-borstackage-b-exedo (AFAIK) not form valid identifiers in Starlark.The version number is factored out into a variable. A simple future improvement would be to simply change that variable in place in the CI pipeline to test other versions.
update-reposdoes assume aWORKSPACEsetup.closes #63 #66