Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node commands which have corresponding bash commands and delete bash command #22

Open
seanmccleary opened this issue Oct 3, 2024 · 0 comments · May be fixed by #25
Open

Update node commands which have corresponding bash commands and delete bash command #22

seanmccleary opened this issue Oct 3, 2024 · 0 comments · May be fixed by #25
Assignees

Comments

@seanmccleary
Copy link
Collaborator

Many of the node commands were originally written in bash and then ported to node. But the original bash scripts were not deleted, and may have had changes/fixed made to them since then. We need to:

  1. Find all node commands that have an equivalent bash command (e.g. "check_migrations")
  2. View the git history to see if the bash command has had any changes/fixed made to it after the node version was created
  3. Incorporate those changes/fixed into the node version, to bring it to feature parity with the bash version
  4. Delete the bash version, so we don't have this duplication going on
  5. Ensure documentation is updated to remove references to the bash version
@artley artley self-assigned this Oct 7, 2024
@seanmccleary seanmccleary changed the title Update node commands which have corresponding bash commands and delete node command Update node commands which have corresponding bash commands and delete bash command Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants