Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/22 update node commands which have corresponding bash commands and delete bash command #25

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

artley
Copy link
Collaborator

@artley artley commented Oct 10, 2024

Change

  • Fixing find_log_errors.js to incorporate the changes from the bash script
  • Deleting unused bash scripts that were introduced as node
  • Updating the documentation.

Does this PR introduce a breaking change?

Might be considered as a braking change, as some of the bash scripts that have node equivalents are being removed.

What needs to be documented once your changes are merged?

Should be nothing, documentation was updated.

Additional Comments

None

@artley artley self-assigned this Oct 10, 2024
@seanmccleary seanmccleary changed the title Feature/22 update node commands which have corresponding bash commands and delete node command Feature/22 update node commands which have corresponding bash commands and delete bash command Oct 10, 2024
Copy link
Collaborator

@seanmccleary seanmccleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I'd like to get @ajmalmsali 's eyes on this too if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update node commands which have corresponding bash commands and delete bash command
2 participants