Added from_* functions for easy deserialization for crates using nickel as a lib
#2099
Conversation
core/src/deserialize.rs
Outdated
| @@ -30,6 +35,70 @@ macro_rules! deserialize_number { | |||
| }; | |||
| } | |||
|
|
|||
| #[derive(Debug, PartialEq)] | |||
| pub enum EvalOrDeserError { | |||
| Nickel(crate::error::Error), | |||
There was a problem hiding this comment.
Maybe a Nickel { error: crate::error::Error, files: crate::files::Files } would be better here, since it would allow the caller to print nice diagnostics if they want to.
There was a problem hiding this comment.
I'm having trouble figuring out the right way to turn an Input into a Files. When constructing EvalOrDeserError from a crate::error::Error, what should files look like? It seems like there is a bit of a chicken and egg problem, where constructing Files requires reading a file, which can fail, which can return the very error we're trying to construct...
There was a problem hiding this comment.
You get the Files from the Program, like here
(edit: the reason you can't get Files directly from the input is that Files can include more things, like imports that were discovered while interpreting the original input)
Bencher ReportChanged `from_input` to write to `NullReporter`
Closes #2097