Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing implementation of from_ast for Record #2100

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

yannham
Copy link
Member

@yannham yannham commented Nov 20, 2024

While testing #2083 I realized that I left a todo!() in the translation of the new AST to mainline Term. This PR adds the missing case. I also removed RecordAttrs that were copy pasted when introducing the new AST, but since we only store an open flag, I ended up using a simple bool field so this type is just unused now.

@yannham yannham requested a review from jneem November 20, 2024 09:37
@yannham yannham added this pull request to the merge queue Nov 20, 2024
Merged via the queue into master with commit f2caf36 Nov 20, 2024
5 checks passed
@yannham yannham deleted the rfc007/add-missing-from-record-ast branch November 20, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants