Set rulesGoStdlibPrefix as ldflag of go_tool_binary #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt toolchain with changes from bazel-contrib/rules_go#3701
benradf
approved these changes
Nov 3, 2023
This was referenced Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt toolchain with changes from bazel-contrib/rules_go#3701
Fixes #421
I'm not fully convinced if this is a correct fix. I'm not sure if this sets a working stdlib prefix and I don't know how to test.
This also breaks compatibility with older versions of rules_go (that are missing therulesGoStdlibPrefixvariable in the source code of thebuilderand theldflagsattribute in thego_tool_binaryrule.@fmeum I know you are probably not involved with rules_nixpkgs, but do you have any guidance for external providers of rules_go
go_toolchains?