Exclude .bazeliskrc from git archive #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #373
The issue reported at #373 is that Zip archives are not allowed to include symlinks that go outside of the extracted folders. This is a problem for rules_nixpkgs, because the core and toolchain modules are meant to be extracted with
strip_prefixset tocore,toolchains/python, etc.The specific issue with
.bazelrcfiles has been resolved since, by replacing symlinks by textual load references in the files themselves.However, since then the repository gained a new set of symlinks:
.bazeliskrcfiles, introduced in fbeacfd. These cannot be replaced by textual references, and we cannot switch to a single toplevel.bazelversionfile as that breaks with a Nix provided Bazel due to NixOS/nixpkgs#80950.This PR solves the issue by excluding these files from Git generated archives via an
export-ignoreentry in.gitattributes.