Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a generic fallback component when initial config load fails #8588

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Display a generic fallback component when initial config load fails #8588

merged 7 commits into from
Nov 22, 2024
+230 −123

Commits on Nov 19, 2024

  1. Introduce isErrored status for handling initial page loading failure

    @khuddite
    khuddite committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    552d6d1 View commit details
    Browse the repository at this point in the history

  2. Style updates for fallback container for responsiveness & introduce i… 

    …sInitialFetch flag
    @khuddite
    khuddite committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    ae2f193 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Introduce BaseThemeProvider, turn AppThemeProvider into effect, code-… 

    …splitting and address PR comments
    @khuddite
    khuddite committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b004845 View commit details
    Browse the repository at this point in the history

  2. Rename AppThemeProviderEffect to UserThemeProviderEffect

    @khuddite
    khuddite committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7f9fce1 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. We avoid useEffect/useMemo unless strictly necessary, I dont think th… 

    …ey are here?
    @FelixMalfait
    FelixMalfait committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    9ada829 View commit details
    Browse the repository at this point in the history

  2. It seems we can remove this tech debt? Am I missing something?

    @FelixMalfait
    FelixMalfait committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4d1dd8a View commit details
    Browse the repository at this point in the history

  3. More common syntax

    @FelixMalfait
    FelixMalfait committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    c9f9250 View commit details
    Browse the repository at this point in the history