Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): add IS_MULTIWORKSPACE_ENABLE flag #8589

Closed

Conversation

AMoreaux
Copy link
Contributor

@AMoreaux AMoreaux commented Nov 19, 2024

Summary

Add support for multi-workspace feature and adjust configurations and states accordingly.

  • Introduced new state isMultiWorkspaceEnabledState.
  • Updated ClientConfigProviderEffect component to handle multi-workspace.
  • Modified GraphQL schema and queries to include multi-workspace related configurations.
  • Adjusted server environment variables and their respective documentation to support multi-workspace toggle.
  • Updated server-side logic to handle new multi-workspace configurations and conditions.

Replaced the 'IS_SIGN_UP_DISABLED' flag with 'IS_MULTIWORKSPACE_ENABLED' to control workspace creation. This change allows for conditional workspace setup based on the new environment variable. Also updated related service, resolver, and entity files.
Updated the IS_MULTIWORKSPACE_ENABLED setting description to indicate support for multiple workspaces. This update clarifies that a web server capable of managing subdomain wildcards is required.
Updated the .env.example file to replace the IS_SIGN_UP_DISABLED variable with IS_MULTIWORKSPACE_ENABLED. Removed the IS_SIGN_UP_DISABLED property from environment-variables.ts as it is no longer needed.
…nabled

Removed isSignUpDisabledState and associated references, and replaced them with isMultiworkspaceEnabledState. Updated GraphQL queries and related components to reflect this change, and ensured multi-workspace functionality is enabled where applicable.
Copy link

github-actions bot commented Nov 19, 2024

Warnings
⚠️ Changes were made to the environment variables, but not to the documentation - Please review your changes and check if a change needs to be documented!

Generated by 🚫 dangerJS against 3037ff5

Corrected the casing of the `isMultiWorkspaceEnabled` variable in the NavigationDrawerHeader component. This ensures consistent naming conventions and avoids potential bugs related to variable misnaming.
@AMoreaux
Copy link
Contributor Author

⚠️ Before merging it wait for the PR that adds subdomains.

@AMoreaux AMoreaux changed the title Feat/add is multi workspace flag feat(): add IS_MULTIWORKSPACE_ENABLE flag Nov 20, 2024
@AMoreaux
Copy link
Contributor Author

Fix #8386 (comment)

@AMoreaux
Copy link
Contributor Author

Close in favor of #8656

@AMoreaux AMoreaux closed this Nov 21, 2024
@AMoreaux AMoreaux deleted the feat/add-is-multi-workspace-flag branch November 21, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant