Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array edit option #8600

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −0
Open

Fix array edit option #8600

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff1a6c5
Fix array edit option
BKM14 Nov 20, 2024
636d9ad
Merge remote-tracking branch 'upstream/main' into v2
ehconitin Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...rc/modules/object-record/record-field/meta-types/input/components/MultiItemFieldInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ export const MultiItemFieldInput = <T,>({
item = items[index] as PhoneRecord;
setInputValue(item.countryCode + item.number);
break;
case FieldMetadataType.Array:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there no break condition for this? is the break condition for emails and arrays the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the break statement for Array and Email are the same. The way the Array is being handled in the backend is just like the Email. So I found it better to use the same block as the Email one

case FieldMetadataType.Emails:
item = items[index] as string;
setInputValue(item);
Expand Down
Loading