-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(auth): clean up and enhance sign-in-up logic #8653
base: feat/allow-to-select-auth-methods-by-workspace
Are you sure you want to change the base?
refactor(auth): clean up and enhance sign-in-up logic #8653
Commits on Nov 19, 2024
-
refactor(auth): clean up and enhance sign-in-up logic
Reorganized the sign-in-up code for better readability and maintainability. Introduced validation for workspace invitations and moved some utility functions to dedicated methods. Added a migration for new auth provider columns in the workspace entity.
Configuration menu - View commit details
-
Copy full SHA for 5ba0266 - Browse repository at this point
Copy the full SHA 5ba0266View commit details -
refactor: remove unused code and streamline checks
Removed unused `EnvironmentService` and redundant `code` property in exceptions for clarity. Simplified email validation in `workspace-invitation.service.ts`. Refactored tests to remove unnecessary `targetWorkspaceSubdomain` property.
Configuration menu - View commit details
-
Copy full SHA for 2598ab1 - Browse repository at this point
Copy the full SHA 2598ab1View commit details -
refactor(auth, core): remove unused services and log debug info
Removed redundant services from auth and core modules to streamline the code. Added debug log statements in sign-in-up service and skipped certain test cases temporarily for evaluation.
Configuration menu - View commit details
-
Copy full SHA for 1433b24 - Browse repository at this point
Copy the full SHA 1433b24View commit details
Commits on Nov 20, 2024
-
refactor(auth): remove console.log statements
Eliminate debug logging for workspace invite tokens and validation. This cleanup improves readability and reduces console clutter during runtime.
Configuration menu - View commit details
-
Copy full SHA for 8279057 - Browse repository at this point
Copy the full SHA 8279057View commit details
Commits on Nov 21, 2024
-
Merge remote-tracking branch 'upstream/main' into refacto/improve-sig…
…ninup # Conflicts: # packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.ts
Configuration menu - View commit details
-
Copy full SHA for 703a776 - Browse repository at this point
Copy the full SHA 703a776View commit details
Commits on Nov 22, 2024
-
Merge branch 'feat/allow-to-select-auth-methods-by-workspace' into re…
…facto/improve-signinup # Conflicts: # packages/twenty-server/src/engine/core-modules/auth/dto/available-workspaces.output.ts # packages/twenty-server/src/engine/core-modules/auth/services/auth.service.ts # packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.ts # packages/twenty-server/src/engine/core-modules/user/services/user.service.ts # packages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.ts
Configuration menu - View commit details
-
Copy full SHA for 595a713 - Browse repository at this point
Copy the full SHA 595a713View commit details -
fix(workspace-invitation): remove redundant code property
Removed the redundant `code` property from WorkspaceInvitationException. Adjusted the import order in WorkspaceResolver to comply with coding standards.
Configuration menu - View commit details
-
Copy full SHA for f6705aa - Browse repository at this point
Copy the full SHA f6705aaView commit details -
Merge branch 'feat/allow-to-select-auth-methods-by-workspace' into re…
…facto/improve-signinup
Configuration menu - View commit details
-
Copy full SHA for dbcad4a - Browse repository at this point
Copy the full SHA dbcad4aView commit details -
fix(auth.service): correct parameter in saveDefaultWorkspace call
Replace user object with user ID in saveDefaultWorkspace method call to fix incorrect parameter type. This ensures that the function operates as expected and prevents potential errors in default workspace assignment.
Configuration menu - View commit details
-
Copy full SHA for 2dfcc6f - Browse repository at this point
Copy the full SHA 2dfcc6fView commit details