Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(auth): clean up and enhance sign-in-up logic #8653

Open
wants to merge 9 commits into
base: feat/allow-to-select-auth-methods-by-workspace
Choose a base branch
from

Commits on Nov 19, 2024

  1. refactor(auth): clean up and enhance sign-in-up logic

    Reorganized the sign-in-up code for better readability and maintainability. Introduced validation for workspace invitations and moved some utility functions to dedicated methods. Added a migration for new auth provider columns in the workspace entity.
    AMoreaux committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5ba0266 View commit details
    Browse the repository at this point in the history
  2. refactor: remove unused code and streamline checks

    Removed unused `EnvironmentService` and redundant `code` property in exceptions for clarity. Simplified email validation in `workspace-invitation.service.ts`. Refactored tests to remove unnecessary `targetWorkspaceSubdomain` property.
    AMoreaux committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2598ab1 View commit details
    Browse the repository at this point in the history
  3. refactor(auth, core): remove unused services and log debug info

    Removed redundant services from auth and core modules to streamline the code. Added debug log statements in sign-in-up service and skipped certain test cases temporarily for evaluation.
    AMoreaux committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    1433b24 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. refactor(auth): remove console.log statements

    Eliminate debug logging for workspace invite tokens and validation. This cleanup improves readability and reduces console clutter during runtime.
    AMoreaux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8279057 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Merge remote-tracking branch 'upstream/main' into refacto/improve-sig…

    …ninup
    
    # Conflicts:
    #	packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.ts
    AMoreaux committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    703a776 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Merge branch 'feat/allow-to-select-auth-methods-by-workspace' into re…

    …facto/improve-signinup
    
    # Conflicts:
    #	packages/twenty-server/src/engine/core-modules/auth/dto/available-workspaces.output.ts
    #	packages/twenty-server/src/engine/core-modules/auth/services/auth.service.ts
    #	packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.ts
    #	packages/twenty-server/src/engine/core-modules/user/services/user.service.ts
    #	packages/twenty-server/src/engine/core-modules/workspace/services/workspace.service.ts
    AMoreaux committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    595a713 View commit details
    Browse the repository at this point in the history
  2. fix(workspace-invitation): remove redundant code property

    Removed the redundant `code` property from WorkspaceInvitationException. Adjusted the import order in WorkspaceResolver to comply with coding standards.
    AMoreaux committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f6705aa View commit details
    Browse the repository at this point in the history
  3. Merge branch 'feat/allow-to-select-auth-methods-by-workspace' into re…

    …facto/improve-signinup
    AMoreaux committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    dbcad4a View commit details
    Browse the repository at this point in the history
  4. fix(auth.service): correct parameter in saveDefaultWorkspace call

    Replace user object with user ID in saveDefaultWorkspace method call to fix incorrect parameter type. This ensures that the function operates as expected and prevents potential errors in default workspace assignment.
    AMoreaux committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2dfcc6f View commit details
    Browse the repository at this point in the history