Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error field type rich text #8739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Error field type rich text #8739

wants to merge 1 commit into from

Conversation

FelixMalfait
Copy link
Member

@FelixMalfait FelixMalfait commented Nov 25, 2024

fix #8445

It seems linked to commandBar search where we filter tasks/notes by body with ilike.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added temporary support for filtering rich text fields by treating them as regular text fields, addressing errors that occurred when filtering notes and other rich text content.

  • Added RichText case in isRecordMatchingFilter.ts that uses isMatchingStringFilter as a temporary solution
  • Added TODO comment indicating a more comprehensive solution for rich text filtering is planned for Q4'24 when it becomes a composite field
  • Fixes issue Error field type rich text #8445 where rich text fields were causing filtering errors

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error field type rich text
1 participant