Admin panel init #8742
Admin panel init #8742
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces an admin panel with user impersonation and feature flag management capabilities, along with necessary routing and state management changes.
- Added
useImpersonatehook in/settings/admin/hooks/useImpersonate.tsfor user impersonation but missinglastVisitedViewclearing (Clear lastVisitedView when impersonating #7090) - Added feature flag management table in
/settings/admin/components/SettingsAdminFeatureFlags.tsxwithout loading/error states - Added admin panel access control via
canImpersonateflag inAppRouter.tsxandSettingsNavigationDrawerItems.tsx - Refactored
clearSessioninuseAuth.tsto support both sign-out and impersonation flows - Added admin panel route with conditional rendering based on user permissions in
SettingsRoutes.tsx
11 file(s) reviewed, 12 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -69,6 +69,49 @@ export const useAuth = () => { | |||
|
|
|||
| const setDateTimeFormat = useSetRecoilState(dateTimeFormatState); | |||
|
|
|||
| const clearSession = useRecoilCallback( | |||
There was a problem hiding this comment.
logic: clearSession preserves UI states but doesn't clear lastVisitedView from localStorage as required by issue #7090
| margin-top: ${({ theme }) => theme.spacing(0.5)}; | ||
| `; | ||
|
|
||
| const StyledTableHeaderRow = styled(Table)` |
There was a problem hiding this comment.
logic: StyledTableHeaderRow extends Table instead of TableRow, which could cause layout issues
| <TableHeader>Value</TableHeader> | ||
| </TableRow> | ||
| </StyledTableHeaderRow> | ||
| {currentWorkspace?.featureFlags?.map((flag) => ( |
There was a problem hiding this comment.
style: No handling of empty/undefined featureFlags array - should show empty state message
| `; | ||
|
|
||
| export const SettingsAdminFeatureFlags = () => { | ||
| const currentWorkspace = useRecoilValue(currentWorkspaceState); |
There was a problem hiding this comment.
style: No loading or error state handling when fetching currentWorkspace
| <Section> | ||
| <H2Title title="Feature Flags" description="Manage feature flags." /> | ||
|
|
||
| <Table> |
There was a problem hiding this comment.
style: Table structure creates new Table component for each row instead of reusing one table with multiple rows
| setCurrentUser(user); | ||
| setTokenPair(tokens); | ||
| await sleep(0); | ||
| window.location.href = AppPath.Index; |
There was a problem hiding this comment.
logic: setIsLoading(false) missing before redirect - loading state will remain true if navigation fails
| await clearSession(); | ||
| setCurrentUser(user); | ||
| setTokenPair(tokens); |
There was a problem hiding this comment.
logic: lastVisitedView in localStorage needs to be cleared here per issue #7090
| await clearSession(); | ||
| setCurrentUser(user); | ||
| setTokenPair(tokens); | ||
| await sleep(0); |
There was a problem hiding this comment.
style: sleep(0) used without clear purpose - could be removed
| const currentUser = useRecoilValue(currentUserState); | ||
| const isAdminPageEnabled = currentUser?.canImpersonate; |
There was a problem hiding this comment.
style: Consider adding a more explicit name like isAdminEnabled instead of isAdminPageEnabled to match the naming pattern of other feature flags
|
|
||
| export const SettingsAdmin = () => { | ||
| return ( | ||
| <SubMenuTopBarContainer title="Admin Panel" links={[{ children: 'Admin' }]}> |
There was a problem hiding this comment.
style: Consider adding a more descriptive breadcrumb trail (e.g. Settings > Admin Panel) for better navigation context
WIP
Related issues -
#7090
#8547
Master issue -
#4499