Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Ruff #115

Merged
merged 10 commits into from
Sep 9, 2024
Merged

Switch to Ruff #115

merged 10 commits into from
Sep 9, 2024

Conversation

twm
Copy link
Contributor

@twm twm commented Sep 6, 2024

Switch to Ruff and run it on the codebase.

@twm twm force-pushed the 114-ruff branch 3 times, most recently from 0efb541 to d354532 Compare September 7, 2024 05:17
@twm twm requested a review from a team September 7, 2024 05:35
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated.

Change looks good. Only minor comment.

I think that ruff is a great tool to help keep the code clean and the dev team aling with the coding standards

@@ -0,0 +1,8 @@
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just asking.
Why do we need this ?

Why not define this dependency as an extra for dev via [options.extras_require]?

pip install -e .[dev]

I expect that anyone that will do dev work on this repo, will need to install ruff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pinned .txt is what Dependabot updates.

I'm generally not a fan of defining a dev extra because I don't think that this sort of tooling should be part of the public contract that pyproject.toml expresses.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. No problem.

I was expencting dependbot to handle pyproject.toml https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#pip-and-pip-compile

pip and pip-compile

In addition to supporting updates to requirements.txt files, Dependabot supports updates to pyproject.toml files if they follow the PEP 621 standard.

@twm
Copy link
Contributor Author

twm commented Sep 9, 2024

Thank you for the review @adiroiban!

@twm twm merged commit 9f22282 into trunk Sep 9, 2024
8 checks passed
@twm twm deleted the 114-ruff branch September 9, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants