-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Ruff #115
Switch to Ruff #115
Conversation
0efb541
to
d354532
Compare
And update to Tox v4 while at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updated.
Change looks good. Only minor comment.
I think that ruff
is a great tool to help keep the code clean and the dev team aling with the coding standards
@@ -0,0 +1,8 @@ | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just asking.
Why do we need this ?
Why not define this dependency as an extra for dev
via [options.extras_require]
?
pip install -e .[dev]
I expect that anyone that will do dev work on this repo, will need to install ruff
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pinned .txt
is what Dependabot updates.
I'm generally not a fan of defining a dev
extra because I don't think that this sort of tooling should be part of the public contract that pyproject.toml
expresses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. No problem.
I was expencting dependbot to handle pyproject.toml https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#pip-and-pip-compile
pip and pip-compile
In addition to supporting updates to requirements.txt files, Dependabot supports updates to pyproject.toml files if they follow the PEP 621 standard.
Thank you for the review @adiroiban! |
Switch to Ruff and run it on the codebase.