Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx upgrade #648

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Sphinx upgrade #648

merged 5 commits into from
Aug 8, 2023

Conversation

glyph
Copy link
Member

@glyph glyph commented Aug 8, 2023

pull sphinx & sphinx-rtd-theme upgrades together

dependabot bot and others added 3 commits July 4, 2023 00:22
Bumps [sphinx-rtd-theme](https://github.com/readthedocs/sphinx_rtd_theme) from 1.2.1 to 1.2.2.
- [Changelog](https://github.com/readthedocs/sphinx_rtd_theme/blob/master/docs/changelog.rst)
- [Commits](readthedocs/sphinx_rtd_theme@1.2.1...1.2.2)

---
updated-dependencies:
- dependency-name: sphinx-rtd-theme
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 5.0.2 to 7.1.2.
- [Release notes](https://github.com/sphinx-doc/sphinx/releases)
- [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES)
- [Commits](sphinx-doc/sphinx@v5.0.2...v7.1.2)

---
updated-dependencies:
- dependency-name: sphinx
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@glyph glyph requested a review from a team as a code owner August 8, 2023 04:00
@glyph
Copy link
Member Author

glyph commented Aug 8, 2023

Supersedes #647 and #627 .

Mainly I just wanted to see if the release candidate could unblock us, but if someone else would like to merge that's great too.

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On https://klein--648.org.readthedocs.build/en/648/ it looks good.
Thanks

Maybe also update conf.py to update the copyright year.
Right now in the footer of the page we have

© Copyright 2011-2022, Twisted Matrix Labs. Revision f0366cc0.

@glyph glyph merged commit c2ae1b3 into trunk Aug 8, 2023
23 checks passed
@glyph glyph deleted the sphinx-upgrade branch August 8, 2023 21:17
@glyph
Copy link
Member Author

glyph commented Aug 8, 2023

We can address copyright updates and the post-RC sphinx upgrade separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants