This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
Update the futures library. #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just bumps fuutures to a more modern version, some core libraries are pinned to a range that is later than the current t.c. dep. This is the minimum-viable change that makes t.c. libs compatible with our problem lib (boto3).
|
Do you all still use RBC? It looks like the |
|
You can just grab an appropriate version from https://www.reviewboard.org/downloads/rbtools/ |
|
I was just discussing it with stu hood. I am familiar with RBCommons so no problem getting the binary. I just wanted to be sure that it was still the way to review changes. I will send something up in a bit. Thanks! |
kwlzn
pushed a commit
that referenced
this pull request
May 10, 2016
This bumps futures to a more modern version, some useful Python libraries are pinned to a range that is later than the current t.c. `futures` version. ex. boto3 is pinned to `futures>=2.2.0,<4.0.0` for python2.7 This is the minimum-viable change that makes the t.c. libs compatible. Testing Done: Ran ci.sh locally and Travis passed: #428 Bugs closed: 427, 428 Reviewed at https://rbcommons.com/s/twitter/r/3857/
|
Submitted as: e8de9d1 |
|
FYI - I now have https://rbcommons.com/s/twitter/r/3858/ out for the |
kwlzn
added a commit
that referenced
this pull request
May 10, 2016
As Mateo noted in #428, `./rbt` in the commons repo seems to have been broken @ 146de3 due to removal of the underlying virtualenv bits. This RB restores the requisite venv deps and bumps both `virtualenv` and `rbtools` to their latest pypi versions to get `./rbt` functional again. Testing Done: Dogfooded for this very review + green CI @ https://travis-ci.org/twitter/commons/builds/129290520 for good measure. before: ``` [illuminati commons (master)]$ ./rbt --version ./rbt: line 3: build-support/python/libvirtualenv.sh: No such file or directory ./rbt: line 4: setup_virtualenv: command not found ./rbt: line 6: exec: rbt: not found ``` after: ``` [illuminati commons (kwlzn/commons/rbt_fix)]$ ./rbt --version Bootstrapping rbt with requirements RBTools==0.7.6 Using /Users/kwilson/Python/CPython-2.7.11/bin/python2.7 ~/dev/commons/build-support ~/dev/commons % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1799k 100 1799k 0 0 2207k 0 --:--:-- --:--:-- --:--:-- 2205k ... ~/dev/commons New python executable in /Users/kwilson/dev/commons/build-support/rbt.venv/bin/python2.7 Also creating executable in /Users/kwilson/dev/commons/build-support/rbt.venv/bin/python Installing setuptools, pip, wheel...done. Collecting RBTools==0.7.6 Using cached RBTools-0.7.6-py2-none-any.whl Collecting six>=1.8.0 (from RBTools==0.7.6) Using cached six-1.10.0-py2.py3-none-any.whl Installing collected packages: six, RBTools Successfully installed RBTools-0.7.6 six-1.10.0 RBTools 0.7.6 ``` Reviewed at https://rbcommons.com/s/twitter/r/3858/
FHandrick
pushed a commit
to project-draco-hr/commons
that referenced
this pull request
Oct 2, 2016
This bumps futures to a more modern version, some useful Python libraries are pinned to a range that is later than the current t.c. `futures` version. ex. boto3 is pinned to `futures>=2.2.0,<4.0.0` for python2.7 This is the minimum-viable change that makes the t.c. libs compatible. Testing Done: Ran ci.sh locally and Travis passed: twitter-archive/commons#428 Bugs closed: 427, 428 Reviewed at https://rbcommons.com/s/twitter/r/3857/
FHandrick
pushed a commit
to project-draco-hr/commons
that referenced
this pull request
Oct 2, 2016
As Mateo noted in twitter-archive/commons#428, `./rbt` in the commons repo seems to have been broken @ 146de3 due to removal of the underlying virtualenv bits. This RB restores the requisite venv deps and bumps both `virtualenv` and `rbtools` to their latest pypi versions to get `./rbt` functional again. Testing Done: Dogfooded for this very review + green CI @ https://travis-ci.org/twitter/commons/builds/129290520 for good measure. before: ``` [illuminati commons (master)]$ ./rbt --version ./rbt: line 3: build-support/python/libvirtualenv.sh: No such file or directory ./rbt: line 4: setup_virtualenv: command not found ./rbt: line 6: exec: rbt: not found ``` after: ``` [illuminati commons (kwlzn/commons/rbt_fix)]$ ./rbt --version Bootstrapping rbt with requirements RBTools==0.7.6 Using /Users/kwilson/Python/CPython-2.7.11/bin/python2.7 ~/dev/commons/build-support ~/dev/commons % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1799k 100 1799k 0 0 2207k 0 --:--:-- --:--:-- --:--:-- 2205k ... ~/dev/commons New python executable in /Users/kwilson/dev/commons/build-support/rbt.venv/bin/python2.7 Also creating executable in /Users/kwilson/dev/commons/build-support/rbt.venv/bin/python Installing setuptools, pip, wheel...done. Collecting RBTools==0.7.6 Using cached RBTools-0.7.6-py2-none-any.whl Collecting six>=1.8.0 (from RBTools==0.7.6) Using cached six-1.10.0-py2.py3-none-any.whl Installing collected packages: six, RBTools Successfully installed RBTools-0.7.6 six-1.10.0 RBTools 0.7.6 ``` Reviewed at https://rbcommons.com/s/twitter/r/3858/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just bumps futures to a more modern version,
some core libraries are pinned to a range that is
later than the current t.c. dep.
This is the minimum-viable change that makes t.c.
libs compatible with our problem lib (boto3).
Testing done: Ran the ci.sh script, which passes.
References: #427