-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useful isValidHashtag() for java #279
base: master
Are you sure you want to change the base?
Conversation
Passing to @leeaustinadams for review - thanks for the PR! |
Hi @leeaustinadams Any updates on this PR? Thanks! |
Slowly orbiting back around to looking at twitter-text, will get you an update shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other than that one item (required for our internal lint rules)
The implementation references isValidHashtag() in js and valid_hashtag() in ruby
c923cf9
to
c5a2235
Compare
Hi @leeaustinadams I removed the redundant import line. Please take a look. Thank you. |
Thanks! For this repo we need to merge it internally first and then push it back to github. Once that has happened I will close this pull request but you will be attributed in the commit message. |
Hi @leeaustinadams Is there any updates on this PR? |
I'm trying to find a time to distribute this internally as well since we need to do that in order to accept your change and push it back to GitHub. Thank you for your patience. |
Hi @leeaustinadams and @andypiper, I've signed the CLA, but the above check still shows "license/cla Pending — Contributor License Agreement is not signed yet." Do you have any idea why? Thanks. |
I assume this repository is no longer maintained - I'm unable to help here. |
Problem
The functions like isValidHashtag() in js and valid_hashtag() in ruby are useful, but there is no such function for java.
Solution
Add isValidHashtag() in Validator.java and add test cases in ValidatorTest.java.
Result
Java people can easily check if a text is a valid hashtag via isValidHashtag().