Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow emoji domain names #420

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow emoji domain names #420

wants to merge 2 commits into from

Commits on Jul 8, 2023

  1. Bump nokogiri version to make dev environment work

    @mhlz
    mhlz committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    f84433e View commit details
    Browse the repository at this point in the history

  2. Replace idn-ruby with SimpleIDN and add more domain validation 

    idn-ruby is uses libidn2, which, unfortunately, does not recognize
domain names that include emojis such as 🌈🌈🌈.st, even though they are
valid and work in pretty much any modern browser.

Additionally the JS implementation of twitter-text already does
recognize links such as https://🌈🌈🌈.st as valid link entities.

Replacing idn-ruby with another ruby gem that impelements the punycode
conversion and adding some new validation to the is_valid_domain
function allows for https://🌈🌈🌈.st to be returned as a valid link
entity, without accepting any other invalid links that are tested in the
conformity test suite.
    @mhlz
    mhlz committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    72e069d View commit details
    Browse the repository at this point in the history