Skip to content

Commit

Permalink
Merge pull request #758 from twmb/isolation_level
Browse files Browse the repository at this point in the history
kgo: ignore aborted txns if using READ_UNCOMMITTED
  • Loading branch information
twmb authored Jun 8, 2024
2 parents a5b1d0c + 9e32bf9 commit 40589af
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 20 deletions.
19 changes: 0 additions & 19 deletions .github/workflows/vuln.yml

This file was deleted.

5 changes: 4 additions & 1 deletion pkg/kgo/source.go
Original file line number Diff line number Diff line change
Expand Up @@ -1192,7 +1192,10 @@ func (o *cursorOffsetNext) processRespPartition(br *broker, rp *kmsg.FetchRespon
o.hwm = rp.HighWatermark
}

aborter := buildAborter(rp)
var aborter aborter
if br.cl.cfg.isolationLevel == 1 {
aborter = buildAborter(rp)
}

// A response could contain any of message v0, message v1, or record
// batches, and this is solely dictated by the magic byte (not the
Expand Down

0 comments on commit 40589af

Please sign in to comment.