Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/sr: touchups #742

Merged
merged 1 commit into from
May 26, 2024
Merged

pkg/sr: touchups #742

merged 1 commit into from
May 26, 2024

Conversation

twmb
Copy link
Owner

@twmb twmb commented May 26, 2024

  • Renames Opt to ClientOpt
  • Renames SerdeOpt to EncodingOpt
  • Removes Serde.SetDefaults, in favor of the new (and more standard) NewSerde function
  • Adds SerdeOpt, with the ability to set the header that is always used
  • Adds top-level Encode/AppendEncode functions, to be used when you are dynamically encoding types and their ids / indices

This is #506 by @lovromazgon, rebased on master, squashed into one commit, with minor modifications

* Renames Opt to ClientOpt
* Renames SerdeOpt to EncodingOpt
* Adds SerdeOpt, with the ability to set the header that is always used
* Removes Serde.SetDefaults, in favor of the new (and more standard)
  NewSerde function
* Adds top-level Encode/AppendEncode functions, to be used when you are
  dynamically encoding types and their ids / indices

This is #506 by @lovromazgon, rebased on master, squashed into one
commit, with minor modifications
@twmb twmb mentioned this pull request May 26, 2024
@twmb twmb merged commit d70b761 into master May 26, 2024
10 checks passed
@twmb twmb deleted the lovro branch May 26, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants