Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary condition in if statements #806

Closed

Conversation

chakku000
Copy link

The code satisfies the condition in the first line when endTxnErr is not nil.
Therefore, when it reaches the third line, endTxnErr must always be nil. As a result, I think the endTxnErr == nil check in the third line is redundant.

if !willTryCommit || endTxnErr != nil {
    ...
} else if willTryCommit && endTxnErr == nil {
    ...
}

@twmb twmb added the patch label Aug 26, 2024
@chakku000 chakku000 closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants