Fix up missing timezones.

changelog

@@ -2,6 +2,7 @@
   Update devices from device refresh
   Allow old backend to be used.
   Quiet down traditional chimes.
+  Fix up missing timezones.
 0.8.0a12: Use new MQTT backend
 0.8.0a11: Add random user agent support.
 0.8.0a10: Don't request resources for Wirefree doorbells.

pyaarlo/backend.py

@@ -179,17 +179,17 @@ def _request(
             self._arlo.warning("request-error={}".format(type(e).__name__))
             return None
 
-        self._arlo.vdebug("request-end={}".format(r.status_code))
-        if r.status_code != 200:
-            return None
-
         try:
             body = r.json()
             self._arlo.vdebug("request-body=\n{}".format(pprint.pformat(body)))
         except Exception as e:
             self._arlo.warning("body-error={}".format(type(e).__name__))
             return None
 
+        self._arlo.vdebug("request-end={}".format(r.status_code))
+        if r.status_code != 200:
+            return None
+
         if raw:
             return body
 

pyaarlo/base.py

@@ -25,6 +25,7 @@
     SCHEDULE_KEY,
     SIREN_STATE_KEY,
     TEMPERATURE_KEY,
+    TIMEZONE_KEY,
 )
 from .device import ArloDevice
 from .util import time_to_arlotime
@@ -370,6 +371,7 @@ def update_modes(self, initial=False):
                 modes = modes.get(self.unique_id, {})
                 self._parse_modes(modes.get("modes", []))
                 self._parse_schedules(modes.get("schedules", []))
+                self._save(TIMEZONE_KEY,modes.get("olsonTimeZone", None))
             else:
                 self._arlo.error("failed to read modes (v2)")
 

pyaarlo/constant.py

@@ -90,6 +90,7 @@
 SIGNAL_STR_KEY = "signalStrength"
 SIREN_STATE_KEY = "sirenState"
 TEMPERATURE_KEY = "temperature"
+TIMEZONE_KEY = "olsonTimeZone"
 TRADITIONAL_CHIME_KEY = "traditionalChime"
 NIGHTLIGHT_KEY = "nightLight"
 MEDIA_PLAYER_KEY = "mediaPlayer"

pyaarlo/device.py

@@ -13,6 +13,7 @@
     RESOURCE_KEYS,
     RESOURCE_UPDATE_KEYS,
     SIGNAL_STR_KEY,
+    TIMEZONE_KEY,
     XCLOUD_ID_KEY,
 )
 
@@ -171,7 +172,10 @@ def hw_version(self):
     @property
     def timezone(self):
         """Returns the timezone."""
-        return self._attrs.get("properties", {}).get("olsonTimeZone", None)
+        time_zone = self._load(TIMEZONE_KEY, None)
+        if time_zone is None:
+            return self._attrs.get("properties", {}).get("olsonTimeZone", None)
+        return time_zone
 
     @property
     def user_id(self):
@@ -388,6 +392,18 @@ def parent_id(self):
             return self._parent_id
         return self.device_id
 
+    @property
+    def timezone(self):
+        """Returns the timezone.
+
+        Tries to be clever. If it doesn't have a timezone it will try its
+        basestation.
+        """
+        time_zone = super().timezone
+        if time_zone is None:
+            return self.base_station.timezone
+        return time_zone
+
     @property
     def base_station(self):
         """Returns the base station controlling this device.