Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Zstd and Lz4 compression #35

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

gleyba
Copy link
Contributor

@gleyba gleyba commented Jan 7, 2024

No description provided.

@tychedelia tychedelia self-requested a review January 7, 2024 05:48
Copy link
Owner

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for implementing these. Was considering whether it makes sense to put these behind feature but our build time still looks pretty reasonable so not an issue.

error!("Failed to compress buffer: {}", e);
EncodeError
})?;
.map_err(compression_err)?;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for cleanup

@tychedelia tychedelia merged commit b129186 into tychedelia:main Jan 7, 2024
1 check passed
@tychedelia
Copy link
Owner

@gleyba Just published https://crates.io/crates/kafka-protocol/0.8.0 for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants