Cache CI builds #87
Merged
Cache CI builds #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
cache_ci_builds
branch
2 times, most recently
from
a6e020f
to
26a0989
Compare
rukai
force-pushed
the
cache_ci_builds
branch
from
26a0989
to
045772d
Compare
tychedelia
approved these changes
Sep 24, 2024
| with: | ||
| # this line means that only the main branch writes to the cache | ||
| # benefits: save about 7s per workflow by skipping the actual cache write | ||
| # downsides: PRs that update rust version or changes deps will be slower to iterate on due to changes not being cached. |
There was a problem hiding this comment.
Definitely worth the trade-off I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help alleviate the CI runtime cost of #86 a little.
I tested without the
save-ifin order to test caching before this PR is merged, and it looks this PR saves ~30s in CI time.