Replace indexmap with vec #90
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
replace_indexmap_with_vec
branch
from
6f6ab15
to
d93462e
Compare
rukai
force-pushed
the
replace_indexmap_with_vec
branch
from
d93462e
to
6f924cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution for #84
I'll have a go at porting my application to it and report back.
edit:
shotover/shotover-proxy#1759
The benchmark for decoding produce requests improved by 20% !
Fun fact I realized about IndexMap is its actually backed by 2 allocations.
So if we create a HashMap (1 allocation) to construct a request to be batch encoded, and then convert that to a Vec (1 allocation) to be compatible with kafka-protocol, that is actually the same number of allocations as just using IndexMap.
Will think about this some more.