Minor cleanup in PagingSelfAwareStructuredLogger #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `Show` on an `Int` or `String` doesn't have any particular benefit, particularly if it's inside of a string interpolation anyway
Previously the message would be materialized multiple times:
- `1` time in `addMsgCtx`
- `3` or `1 + 3p` times in `pagedLogging`
- Lower Bound (single page): `3` times
- `1` time to calculate the number of pages
- `1` time in `addPageCtx` to calculate the page length
- `1` time when calling `logOpWithCtx`
- Upper Bound (`p` pages): `1 + 3p`
- `1` time to calculate the number of pages
- `1` time per page to split out each page
- `1` time per page in `addPageCtx` to calculate the page length
- `1` time per page when calling `logOpWithCtx`
Materializing early gives these improvements:
- Single page: from `4` times to `1` time
- Multiple pages: from `2 + 3p` times to `1` time
Also removes some by-name parameters that were always called with
materialized values.
rossabaker
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Materialize the paged message before interacting with it.
Previously the message would be materialized multiple times:
1: in call toaddMsgCtx3or1 + 3p: in call topagedLogging31: calculate the number of pages1: in call toaddPageCtx(calculate the page length)1: in call tologOpWithCtxppages):1 + 3p1: calculate the number of pages1p:msgis materialized every time a page is sliced from the message1p: in call toaddPageCtx(calculate the page length)1p: in call tologOpWithCtxMaterializing early gives these improvements:
4times to1time2 + 3ptimes to1timeRemoves some by-name parameters that were always called with materialized values.
Simplifies unneeded calls to
ShowonIntorStringvalues, which doesn't have any particular benefit, particularly if it's inside of a string interpolation anyway.