Easy::Operations#handle: Thread-safe cleanup #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes intermittent segfaults. Unfortunately I don't have an easily reproducible test-case but this change seems to fix segfaults for a live system.
|
Check that, segfaults started re-appearing. |
|
:( does that mean this fix doesn't help? |
|
Unfortunately yes and I'm not sure what else it might be. |
|
This issue you are trying to address is related to ( probably the cause of) typhoeus/typhoeus#452 |
|
This is a very old PR but when using Ruby 2.7.1 segfaults became a clear show stopper in my use-case as This fix immediately took care of my issue although I'm not sure if it'll be 100% effective for all multi-thread related segfaults. I think it's worth merging into |
tagliala
added a commit
to tagliala/ethon
that referenced
this pull request
Jun 10, 2021
This reverts commit b4899b9. Fix typhoeus#194
Kjarrigan
pushed a commit
that referenced
this pull request
Jun 11, 2021
|
I don't think this has fixed the sigfaults for us. We are still seeing them, I've filed: #209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes intermittent segfaults.
Unfortunately I don't have an easily reproducible test-case but this change seems to
fix segfaults for a live system.