Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for biblatex extended name format default nameparts #48

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add support for biblatex extended name format default nameparts #48

merged 1 commit into from
Dec 12, 2023

Conversation

quachpas
Copy link
Contributor

@quachpas quachpas commented Dec 9, 2023

@quachpas quachpas changed the title WIP: Add support for biblatex extended name format default nameparts DRAFT: Add support for biblatex extended name format default nameparts Dec 9, 2023
@quachpas quachpas changed the title DRAFT: Add support for biblatex extended name format default nameparts WIP: Add support for biblatex extended name format default nameparts Dec 9, 2023
@quachpas quachpas marked this pull request as draft December 9, 2023 22:39
@quachpas quachpas mentioned this pull request Dec 9, 2023
Closed
1 task
@quachpas quachpas marked this pull request as ready for review December 10, 2023 14:36
@quachpas quachpas changed the title WIP: Add support for biblatex extended name format default nameparts Add support for biblatex extended name format default nameparts Dec 10, 2023
reknih
reknih reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@reknih reknih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, just a few comments

src/types/person.rs Outdated Show resolved Hide resolved
src/types/person.rs Outdated Show resolved Hide resolved
src/types/person.rs Show resolved Hide resolved
@quachpas
Copy link
Contributor Author

Looking good overall, just a few comments

I modified the implementation to match your suggestions! thanks 😄

reknih
reknih reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@reknih reknih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final nits

src/types/person.rs Outdated Show resolved Hide resolved
src/types/person.rs Outdated Show resolved Hide resolved
@quachpas @reknih
Add support for biblatex extended name format default nameparts
be47a34 
Co-authored-by: Martin Haug <mhaug@live.de>
@quachpas
Copy link
Contributor Author

Thanks again! I added your final suggestions and squashed 🎉

@quachpas quachpas requested a review from reknih December 12, 2023 10:25
@reknih reknih merged commit 66f2cf7 into typst:main Dec 12, 2023
1 check passed
@reknih
Copy link
Member

reknih commented Dec 12, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reknih reknih Awaiting requested review from reknih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support BibLaTeX extended name format
2 participants
@quachpas @reknih