Don't force space after sort separator #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PgBiel
force-pushed
the
fix-space-after-sort-separator
branch
from
39c8022
to
0675bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering inverted names in
nameselements, we were forcing a space after thesort-separator; this PR removes that behavior. For instance, inDoe, Jonesthe sort separator - separating the family name from the given name in the inverted name - is,, but it could also be,(without a space after the comma), in which caseDoe,Joneswould be the correct output per citeproc tests, which seems to match the CSL spec in my interpretation, as it enforces that spaces at the end ofsort-separatorshouldn't be stripped (which I assume to be for this very reason).This makes citeproc tests
nameattr_SortSeparatorOnBibliographyInCitationandsortseparator_SortSeparatorEmptypass. No currently passing citeproc tests seem to fail with this change.