Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #227 #231

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Fix #227 #231

merged 3 commits into from
Oct 10, 2024

Conversation

reknih
Copy link
Member

@reknih reknih commented Oct 9, 2024 •
edited
Loading

With the new page range type, Deserialize only returned Ok if the value was a string. This PR adds conversions for i32, u32, and u64 values which YAML can easily yield for single pages

Fixes #227

@reknih
Fix #227
bcf084c 
With the new page range type, `Deserialize` only returned `Ok` if the value was a string. This PR adds conversions for i32, u32, and u64 values which YAML can easily yield
for single pages
@reknih reknih requested a review from PgBiel October 9, 2024 14:44
@reknih reknih mentioned this pull request Oct 9, 2024
Closed
EpicEricEE
EpicEricEE reviewed Oct 9, 2024
View reviewed changes
src/types/page.rs Outdated Show resolved Hide resolved
PgBiel
PgBiel reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@PgBiel PgBiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK in general. I'll leave a few comments.

src/types/page.rs Outdated Show resolved Hide resolved
src/types/page.rs Show resolved Hide resolved
@reknih reknih merged commit 9e30220 into main Oct 10, 2024
4 checks passed
@reknih reknih deleted the fix-int-page-ranges branch October 10, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PgBiel PgBiel PgBiel left review comments

@EpicEricEE EpicEricEE EpicEricEE left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hayagriva 0.7 breaks due to MaybeTyped
3 participants
@reknih @EpicEricEE @PgBiel