Skip to content

Commit

Permalink
update CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tzerk authored and tzerk committed Jul 20, 2016
1 parent ab1881a commit a6086b8
Showing 1 changed file with 16 additions and 17 deletions.
33 changes: 16 additions & 17 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,25 +1,24 @@
## Resubmission
This is a resubmission. In this version I have:

* Referred in the DESCRIPTION to other packages and external libraries in single quotes.

* Made clear in the DESCRIPTION that this package includes the 'jscolor.js' library.

* Removed the LICENSE file and the reference in the DESCRIPTION

* Added a LICENSE.note file to include comments on the licensing

## Test environments
* local Windows 8 x64 install, R-devel (2015-03-27 r68108)
* ubuntu 14.04 (VM), R 3.1.3
* local Windows 10 x64 install, R-devel (2016-07-16 r70929)
* Ubuntu 12.04 (on Travis-CI), R 3.3.1
* win-builder (devel and release)

## R CMD check results
There were no ERRORs or WARNINGs.

There was 1 NOTE:

* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Christoph Burow <christoph.burow@uni-koeln.de>'
New submission

This is a new submission.
Maintainer: 'Christoph Burow <christoph.burow@uni-koeln.de>'

Possibly mis-spelled words in DESCRIPTION:
chronometric (19:14)
tooltip (20:43)

These are spelled correctly.

## Downstream dependencies
I have also run R CMD check on downstream dependencies of RLumShiny using
devtools::revdep_check() (https://github.com/tzerk/RLumShiny/tree/master/revdep).

All packages passed.

0 comments on commit a6086b8

Please sign in to comment.