Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup protos #115

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Cleanup protos #115

merged 5 commits into from
Nov 14, 2024

Conversation

uatuko
Copy link
Owner

@uatuko uatuko commented Nov 13, 2024

This is mainly to drop google.api.http annotations used for gRPC/JSON transcoding support (9136c98) and to avoid sharing top-level request/response messages across rpcs (29331e3).

gRPC/JSON transcoding support is dropped since Ruek is not expected to be public facing API so there's shouldn't be a need to receive HTTP requests (e.g. from a browser).

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.90%. Comparing base (31d51d3) to head (29331e3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   93.88%   93.90%   +0.02%     
==========================================
  Files          21       21              
  Lines        1406     1411       +5     
  Branches      168      168              
==========================================
+ Hits         1320     1325       +5     
  Misses         59       59              
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uatuko uatuko force-pushed the feature/cleanup-protos branch from 040b4e6 to 29331e3 Compare November 13, 2024 21:26
@uatuko uatuko marked this pull request as ready for review November 13, 2024 21:29
@uatuko uatuko merged commit 3ef1052 into main Nov 14, 2024
4 checks passed
@uatuko uatuko deleted the feature/cleanup-protos branch November 14, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant