Drop Authz and Entities services #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authz and Entities servicers pre-date ReBAC implementation (#73) and currently it's just a wrapper around Relations service. Since having multiple services to access the same data can be confusing and misleading, aim is to focus purely on the Relations service going forward.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 94.06% 95.50% +1.44%
==========================================
Files 21 19 -2
Lines 1448 1246 -202
Branches 169 141 -28
==========================================
- Hits 1362 1190 -172
+ Misses 59 38 -21
+ Partials 27 18 -9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authz and Entities servicers pre-date the ReBAC implementation (#73) and currently it's just a wrapper around the Relations service. Since having multiple services to access the same data can be confusing and misleading, aim is to focus purely on the Relations service going forward.