Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to return correct gRPC errors when creating duplicate relations #120

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

uatuko
Copy link
Owner

@uatuko uatuko commented Dec 17, 2024

Return ALREADY_EXISTS gRPC status when creating duplicate relations.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (d00df95) to head (280bf6c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   95.50%   95.51%   +0.01%     
==========================================
  Files          19       19              
  Lines        1246     1249       +3     
  Branches      141      141              
==========================================
+ Hits         1190     1193       +3     
  Misses         38       38              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uatuko uatuko marked this pull request as ready for review December 17, 2024 21:56
@uatuko uatuko changed the title Fix gRPC errors when creating duplicate relations Fix to return correct gRPC errors when creating duplicate relations Dec 19, 2024
@uatuko uatuko merged commit 9b3f524 into main Dec 19, 2024
4 checks passed
@uatuko uatuko deleted the bugfix/errors branch December 19, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant