Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplification #2

Open
wants to merge 6 commits into
base: DIP
Choose a base branch
from
Open

Simplification #2

wants to merge 6 commits into from

Conversation

chabbimilind
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 6, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ lollllcat
❌ chabbimilind
You have signed the CLA already but the status is still pending? Let us recheck it.

chabbimilind and others added 4 commits May 6, 2021 14:30
@chabbimilind
[bugfix]: added missing continue statement in a conditional.
06ee25f
@chabbimilind
[bugfix] do not combime Call and Defer in the same case.
fc3f8b2 
Call and Defer are different types, hence we cannot type cast Defer to a Call.
Instead, use different case statements to extract the Call.Value present in both of them,
and then we can reuse the rest of the code on the Value type.
@lollllcat
Merge branch 'DIP' into simplification
c399ce1
@lollllcat
fix bug on instruction type
bcab77a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chabbimilind @CLAassistant @lollllcat