Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 23 support #1034

Merged
merged 9 commits into from
Sep 24, 2024
Merged

JDK 23 support #1034

merged 9 commits into from
Sep 24, 2024

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Sep 8, 2024

Also requires bumping WALA. One of our generics tests that did not work before now works correctly on JDK 23, so we tweak the test case according to the running JDK version.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.54%. Comparing base (f36ab25) to head (5a67311).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1034   +/-   ##
=========================================
  Coverage     87.54%   87.54%           
  Complexity     2138     2138           
=========================================
  Files            83       83           
  Lines          7003     7003           
  Branches       1367     1367           
=========================================
  Hits           6131     6131           
  Misses          451      451           
  Partials        421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar changed the title [WIP] JDK 23 support JDK 23 support Sep 22, 2024
@msridhar msridhar marked this pull request as ready for review September 22, 2024 16:50
Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msridhar msridhar merged commit 940c40e into master Sep 24, 2024
11 checks passed
@msridhar msridhar deleted the jdk23-support branch September 24, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants