Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT LAND] @EnsuresNonNullIf benchmarking only #1046

Closed
wants to merge 53 commits into from
Closed

[DO NOT LAND] @EnsuresNonNullIf benchmarking only #1046

wants to merge 53 commits into from

Commits on Sep 24, 2024

  1. First draft of @EnsuresNonNullIf

    @mauricioaniche
    mauricioaniche committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    60c09cd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ensures-non-null-if

    @mauricioaniche
    mauricioaniche authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    dfcfb04 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Improve validation of the semantics of the EnsuresNonNullIfHandler

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c674bf9 View commit details
    Browse the repository at this point in the history

  2. More tests

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c511a79 View commit details
    Browse the repository at this point in the history

  3. Improve docs

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9eac416 View commit details
    Browse the repository at this point in the history

  4. Validate post-conditions in child classes

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    38d6d88 View commit details
    Browse the repository at this point in the history

  5. A few more tests

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c2a5dc2 View commit details
    Browse the repository at this point in the history

  6. Tests cleanup

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    17b9173 View commit details
    Browse the repository at this point in the history

  7. Fix error message in FieldContractUtils

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e4ab9ba View commit details
    Browse the repository at this point in the history

  8. Fix error message in FieldContractUtils again

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9cbcf4e View commit details
    Browse the repository at this point in the history

  9. Add trueIfNonNull to invert the result of the EnsuresNonNullIf method

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d044fae View commit details
    Browse the repository at this point in the history

  10. Throw exception instead of returning default value in exceptional case

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d700ee3 View commit details
    Browse the repository at this point in the history

  11. Rename variable

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6842120 View commit details
    Browse the repository at this point in the history

  12. Fix nullability issues in my code

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    df1293f View commit details
    Browse the repository at this point in the history

  13. One more test

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1bf794c View commit details
    Browse the repository at this point in the history

  14. Move ignored tests to the bottom

    @mauricioaniche
    mauricioaniche committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c471082 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. add TODO

    @msridhar
    msridhar committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6ebac11 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Make use of internal state to get the enclosing method of a return tree

    @mauricioaniche
    mauricioaniche committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3b27dae View commit details
    Browse the repository at this point in the history

  2. Improvements here and there

    @mauricioaniche
    mauricioaniche committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    4aa9ed0 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. New approach

    @mauricioaniche
    mauricioaniche committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    c0a70ac View commit details
    Browse the repository at this point in the history

  2. Code review feedback

    @mauricioaniche
    mauricioaniche committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    5f2ad31 View commit details
    Browse the repository at this point in the history

  3. Nit on javadoc

    @mauricioaniche
    mauricioaniche committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3ad3944 View commit details
    Browse the repository at this point in the history

  4. Nit in comments

    @mauricioaniche
    mauricioaniche committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3afb836 View commit details
    Browse the repository at this point in the history

  5. Put class back to original state to reduce changes in PR

    @mauricioaniche
    mauricioaniche committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    de81671 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Got it working

    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    92b3a77 View commit details
    Browse the repository at this point in the history

  2. Cleaning up the doc and more docs

    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    04a7d42 View commit details
    Browse the repository at this point in the history

  3. Fix clean up

    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    ee32c48 View commit details
    Browse the repository at this point in the history

  4. More fixes

    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    81b1edc View commit details
    Browse the repository at this point in the history

  5. Rename trueIfNonNull to result and make it compulsory, to match Check… 

    …erFramework
    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    fbd05a7 View commit details
    Browse the repository at this point in the history

  6. More cleanups

    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    b1faf00 View commit details
    Browse the repository at this point in the history

  7. Handle missing case where allFieldsInPathAreVerified is false and eva… 

    …luatesToLiteral
    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    0f71fde View commit details
    Browse the repository at this point in the history

  8. nit comment

    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    880ae42 View commit details
    Browse the repository at this point in the history

  9. one more test

    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    f478ac4 View commit details
    Browse the repository at this point in the history

  10. one more test

    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    d53958b View commit details
    Browse the repository at this point in the history

  11. FIX typo name of the test

    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    13b0cca View commit details
    Browse the repository at this point in the history

  12. FIX typo name of the test

    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    5d8157d View commit details
    Browse the repository at this point in the history

  13. one more test

    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    2623bfa View commit details
    Browse the repository at this point in the history

  14. Fix nullaway issues in nullaway

    @mauricioaniche
    mauricioaniche committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    1b1967c View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. JSpecify annotation

    @mauricioaniche
    mauricioaniche committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    80ef2ca View commit details
    Browse the repository at this point in the history

  2. small refactoring; fix compilation

    @mauricioaniche
    mauricioaniche committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5428602 View commit details
    Browse the repository at this point in the history

  3. Use elseStore when result is set to false

    @mauricioaniche
    mauricioaniche committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ca7a54a View commit details
    Browse the repository at this point in the history

  4. Set return default value to true again

    @mauricioaniche
    mauricioaniche committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    bb139df View commit details
    Browse the repository at this point in the history

  5. Improve tests

    @mauricioaniche
    mauricioaniche committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f23a8d4 View commit details
    Browse the repository at this point in the history

  6. test for error message when result=false

    @mauricioaniche
    mauricioaniche committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    45907e1 View commit details
    Browse the repository at this point in the history

  7. Return true in case body is null just like existing EnsureNonNull han… 

    …dler
    @mauricioaniche
    mauricioaniche committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7a3d075 View commit details
    Browse the repository at this point in the history

  8. simplify error message

    @mauricioaniche
    mauricioaniche committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3c7295e View commit details
    Browse the repository at this point in the history

  9. Broken test

    @mauricioaniche
    mauricioaniche committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2bbbac2 View commit details
    Browse the repository at this point in the history

  10. Fix issue when return=false and method returns boolean

    @mauricioaniche
    mauricioaniche committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ea10969 View commit details
    Browse the repository at this point in the history

  11. Let's not use an Optional here. Since we check the code with NullAway… 

    …, using null should be fine
    @msridhar
    msridhar committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3cb7d51 View commit details
    Browse the repository at this point in the history

  12. No need to report when all paths are verified but return is wrong

    @mauricioaniche
    mauricioaniche committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    56a0984 View commit details
    Browse the repository at this point in the history

  13. minor comment tweak

    @msridhar
    msridhar committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    f98fb3c View commit details
    Browse the repository at this point in the history

  14. simplify dataflow update logic

    @msridhar
    msridhar committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fa7728e View commit details
    Browse the repository at this point in the history

  15. comments

    @msridhar
    msridhar committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1c5610c View commit details
    Browse the repository at this point in the history